Fix ESLint v10 RuleContext API removal (follow-up to #3972) by ledsun · Pull Request #3979 · jsx-eslint/eslint-plugin-react

ledsun · 2026-02-09T02:35:00Z

This PR follows up on the feedback in the comments of #3972 and incorporates the requested changes.

I think this PR will fix #3977.

ljharb

we'll need regression tests - it might be as simple as adding eslint 10 to the GHA matrix.

@ledsun

Use @ledsun fork. For more see: - jsx-eslint/eslint-plugin-react#3977 - jsx-eslint/eslint-plugin-react#3979

@ledsun

Use @ledsun fork. For more see: - jsx-eslint/eslint-plugin-react#3977 - jsx-eslint/eslint-plugin-react#3979

jsx-eslint#3972

codecov · 2026-02-11T08:15:43Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.68%. Comparing base (25249f3) to head (a3a41eb).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3979      +/-   ##
==========================================
- Coverage   97.85%   97.68%   -0.17%     
==========================================
  Files         136      136              
  Lines       10008    10014       +6     
  Branches     3717     3718       +1     
==========================================
- Hits         9793     9782      -11     
- Misses        215      232      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Run published type checks against both ESLint 7 and 10. Use per-matrix dependency setup and exclude unsupported TS combinations for ESLint 10.

- route filename/sourceCode access through util helpers for ESLint 7/10 compatibility - remove deprecated meta.docs.category to satisfy current RuleModule typings - augment @eslint/core SettingsConfig with react settings shape

lib/util/eslint.js

lib/util/version.js

Co-authored-by: Dom Armstrong <dom@dom-armstrong.co.uk>

lib/util/makeNoMethodSetStateRule.js

ljharb · 2026-02-13T05:33:57Z

.github/workflows/node-18+.yml

      matrix:
        node-version: ${{ fromJson(needs.matrix.outputs.latest) }}
        eslint:
+          - 10


you'll also need to exclude eslint 10 on node < 20

To keep the total number of matrices under 256, I also excluded the combination of ESLint 10 and babel-eslint 8. If you know of a better combination, please let me know.

ljharb · 2026-02-13T05:34:48Z

lib/util/version.js

 const resolve = require('resolve');
 const semver = require('semver');
 const error = require('./error');
+const eslintUtil = require('./eslint');


Suggested change

const eslintUtil = require('./eslint');

const getFilename = require('./eslint').getFilename;

ljharb · 2026-02-13T05:35:28Z

package.json

    "@typescript-eslint/parser": "^2.34.0 || ^3.10.1 || ^4 || ^5 || ^6.20 || ^7.14.1 || 8.4 - 8.17",
    "babel-eslint": "^8 || ^9 || ^10.1.0",
-    "eslint": "^3 || ^4 || ^5 || ^6 || ^7 || ^8 || ^9.7",
+    "eslint": "^3 || ^4 || ^5 || ^6 || ^7 || ^8 || ^9.7 || ^10.0",


this might be premature; it's fine if the eslint 10 tests don't completely pass after this PR, and this line is what actually adds support for it.

however obv if this PR is sufficient to support eslint 10, this is great :-)

I made the correction. I mistakenly thought it was necessary to run the combination of GitHub Actions.

…SetStateRule

…orkaround until stable release

ljharb reviewed Feb 10, 2026

View reviewed changes

ljharb marked this pull request as draft February 10, 2026 02:09

sergeyklay added a commit to sergeyklay/oar that referenced this pull request Feb 10, 2026

chore(deps-dev): bump eslint from 9.39.2 to 10.0.0

72b1aaf

Use @ledsun fork. For more see: - jsx-eslint/eslint-plugin-react#3977 - jsx-eslint/eslint-plugin-react#3979

sergeyklay mentioned this pull request Feb 10, 2026

chore(deps-dev): bump eslint from 9.39.2 to 10.0.0 sergeyklay/oar#269

Merged

sergeyklay added a commit to sergeyklay/oar that referenced this pull request Feb 10, 2026

chore(deps-dev): bump eslint from 9.39.2 to 10.0.0

30bc6ee

Use @ledsun fork. For more see: - jsx-eslint/eslint-plugin-react#3977 - jsx-eslint/eslint-plugin-react#3979

sergeyklay mentioned this pull request Feb 10, 2026

Track reverting to upstream eslint after temporary fork sergeyklay/oar#270

Open

Copilot AI mentioned this pull request Feb 10, 2026

docs: create ESLint 10 compatibility tracking document sergeyklay/oar#271

Closed

sergeyklay mentioned this pull request Feb 10, 2026

Tracking: ESLint 10 Support sergeyklay/oar#272

Open

6 tasks

tylermumford and others added 3 commits February 11, 2026 17:03

Update types and RuleContext deprecations

69b7fc4

Addresses the feedback provided in the comments on

9c686b5

jsx-eslint#3972

Add ESLint 10 to the Node 18+ CI matrix

a7b967b

ledsun force-pushed the update-deprecated-calls-v8 branch from f987ffa to a7b967b Compare February 11, 2026 08:06

ledsun added 6 commits February 11, 2026 18:59

ci(types): split type-check matrix by ESLint major (7/10)

9932114

Run published type checks against both ESLint 7 and 10. Use per-matrix dependency setup and exclude unsupported TS combinations for ESLint 10.

fix(types): align rule context usage with ESLint 10 typings

54908ab

- route filename/sourceCode access through util helpers for ESLint 7/10 compatibility - remove deprecated meta.docs.category to satisfy current RuleModule typings - augment @eslint/core SettingsConfig with react settings shape

chore: add ESLint v10 support to package.json

56cd100

chore: Add ESLint v10 support to peer dependency

d143827

ci(type-check): install eslint before typescript in test-published-types

4b2162e

ci(type-check): limit ESLint 10 matrix to TypeScript 5+

1cbaa2f

ledsun marked this pull request as ready for review February 11, 2026 12:08

domarmstrong reviewed Feb 12, 2026

View reviewed changes

lib/util/eslint.js Outdated Show resolved Hide resolved

lib/util/version.js Outdated Show resolved Hide resolved

ledsun and others added 2 commits February 12, 2026 21:02

Apply suggestions from code review

4daabd7

Co-authored-by: Dom Armstrong <dom@dom-armstrong.co.uk>

Fix getFilename utility and import usage in version resolver

ce94759

ljharb reviewed Feb 12, 2026

View reviewed changes

lib/util/makeNoMethodSetStateRule.js Show resolved Hide resolved

Reverse unintended changes

33e30c8

ljharb requested changes Feb 13, 2026

View reviewed changes

Copilot AI mentioned this pull request Feb 14, 2026

Downgrade ESLint to v9.39.2 due to plugin incompatibility cybersemics/em#3804

Closed

5 tasks

ledsun added 3 commits February 15, 2026 16:37

fix(types): avoid RulesMetaDocs excess-property check in makeNoMethod…

745d588

…SetStateRule

chore(peer-deps): drop eslint v10 from declared support range

3023a29

chore(dev-deps): drop eslint v10 from development range

808ca3c

ledsun added 4 commits February 15, 2026 17:10

refactor(version): import only getFilename from eslint util

15a8614

ci: run ESLint 10 matrix jobs on Node 20+ only

3fbb319

ci: exclude ESLint 10 + babel-eslint 8 from matrix

939967d

ci: use @typescript-eslint/parser@canary for ESLint 10 as temporary w…

a3a41eb

…orkaround until stable release

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix ESLint v10 RuleContext API removal (follow-up to #3972)#3979

Fix ESLint v10 RuleContext API removal (follow-up to #3972)#3979
ledsun wants to merge 19 commits intojsx-eslint:masterfrom
ledsun:update-deprecated-calls-v8

ledsun commented Feb 9, 2026 •

edited

Loading

Uh oh!

ljharb left a comment

Uh oh!

codecov bot commented Feb 11, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ljharb Feb 13, 2026

Uh oh!

ledsun Feb 15, 2026

Uh oh!

ljharb Feb 13, 2026

Uh oh!

ljharb Feb 13, 2026

Uh oh!

ledsun Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

	const eslintUtil = require('./eslint');
	const getFilename = require('./eslint').getFilename;

Uh oh!

Conversation

ledsun commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ljharb left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ljharb Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

ledsun Feb 15, 2026

Choose a reason for hiding this comment

Uh oh!

ljharb Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

ljharb Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

ledsun Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

ledsun commented Feb 9, 2026 •

edited

Loading

codecov bot commented Feb 11, 2026 •

edited

Loading